Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow_stopping_for_updates should not restrict changes when the instance is stopped. #5828

Closed
davegalos opened this issue Mar 4, 2020 · 3 comments
Assignees

Comments

@davegalos
Copy link

provider.google v2.17.0
Terraform v0.12.13

Right now the code simply aborts if allow_stopping_for_updates=false and if certain fields are being modified. If the instance is stopped; however these there is no need to abort, these fields can be updated with no special confirmation. A flag to bring up the stopped instance in this situation would be useful as well.

@edwardmedia edwardmedia self-assigned this Mar 5, 2020
@edwardmedia
Copy link
Contributor

@davegalos do you mind if you can open an enhancement instead? Please use the template and state your suggestions and business needs. I am closing this issue right now. In that way we can prioritize each item in the backlog. Thank you

@rileykarson
Copy link
Collaborator

Hey @davegalos! This is actually supported as-of https://github.com/terraform-providers/terraform-provider-google/blob/master/CHANGELOG.md#3110-march-02-2020. It isn't stated explicitly, but #4797 added the behaviour.

Prior to that change, Terraform assumed that instances were always in the RUNNING state, so stopped instances weren't handled as well as they could be.

@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants