Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the provider from vendoring dependencies to gomodules #5789

Closed
6 tasks done
chrisst opened this issue Feb 27, 2020 · 2 comments
Closed
6 tasks done

Move the provider from vendoring dependencies to gomodules #5789

chrisst opened this issue Feb 27, 2020 · 2 comments

Comments

@chrisst
Copy link
Contributor

chrisst commented Feb 27, 2020

We are currently checking in the whole vendor folder into github and also the go.mod. The only thing keeping these in sync is a manual process.

  • Ensure that magic modules can generate the correct imports once the vendor directory is removed
  • Change the makefiles in TPG and TPGB to remove mod=vendor references
  • Update the kokoro build files to remove any references to vendoring
  • Update the HashiCorp build process to work with go modules
  • Remove the vendor folder
  • Update the documentation that refers to the vendor process
@nat-henderson
Copy link
Contributor

@megan07, have you seen #6306 and are you planning on addressing it here? If not we can discuss next week.

@ghost
Copy link

ghost commented Jun 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants