Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support compute.reservations.resize #4937

Comments

@bmenasha
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Currently when changing google_compute_reservation.specific_reservation.count Terraform will delete the existing reservation and attempt to provision a new one.

This can cause the loss of the existing whole reservation which can cause lots of problems for a zone under capacity pressure which is the whole point of this reservations feature!

Can we please support the resize method compute.reservations.resize so a user can safely grow an existing reservation without losing the reservation when the new capacity fails to provision?

Thanks

New or Affected Resource(s)

google_compute_reservation

@ghost ghost added the enhancement label Nov 18, 2019
@paddycarver paddycarver added this to the Goals milestone Dec 3, 2019
@danawillow
Copy link
Contributor

google-internal request: b/145758596

@ghost
Copy link

ghost commented Apr 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.