Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pubsub Subscription should allow updating push config #455

Closed
rosbo opened this issue Sep 25, 2017 · 2 comments · Fixed by #512
Closed

Pubsub Subscription should allow updating push config #455

rosbo opened this issue Sep 25, 2017 · 2 comments · Fixed by #512
Assignees

Comments

@rosbo
Copy link
Contributor

rosbo commented Sep 25, 2017

Remove ForceNew, implement an update method leveraging this APIs:

@rosbo rosbo changed the title Pubsub Subscription ACK deadline and push config now have update methods. Pubsub Subscription should allow updating ACK deadline and push config Sep 25, 2017
@rosbo rosbo self-assigned this Sep 28, 2017
@rosbo rosbo changed the title Pubsub Subscription should allow updating ACK deadline and push config Pubsub Subscription should allow updating push config Oct 2, 2017
@rosbo
Copy link
Contributor Author

rosbo commented Oct 2, 2017

ACK deadline at the subscription level cannot be modified. The modifyAckDeadline method allows to update ack deadline only for specific messages. See:
https://cloud.google.com/pubsub/docs/reference/rest/v1/projects.subscriptions/modifyAckDeadline

Updated the issue title and description to reflect that only the push config can be updated.

@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants