Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty taint config block when using nvidia.com/gpu key on GKE #4520

Closed
michal0A opened this issue Sep 23, 2019 · 2 comments
Closed

Empty taint config block when using nvidia.com/gpu key on GKE #4520

michal0A opened this issue Sep 23, 2019 · 2 comments
Labels
bug forward/review In review; remove label to forward service/container

Comments

@michal0A
Copy link

michal0A commented Sep 23, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
  • If an issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to "hashibot", a community member has claimed the issue already.

Terraform Version

Terraform v0.12.8

  • provider.google v2.15.0
  • provider.google-beta v2.15.0

Affected Resource(s)

google_container_node_pool

Terraform Configuration Files

resource "google_container_node_pool" "gpu_node_pool" {
  provider = "google-beta"

  name     = "gpu_node_pool"

  zone   = "${var.zone}"
  cluster  = "${google_container_cluster.cluster.name}"

  node_config {
    machine_type     = "n1-standard-4"

    guest_accelerator {
      type  = "nvidia-tesla-k80",
      count = 1
    }

    taint {
      key    = "nvidia.com/gpu"
      value  = "present"
      effect = "NO_SCHEDULE"
    }
  }
}

Debug Output

2019/09/23 12:34:56 [WARN] Provider "google-beta" produced an invalid plan for module.research.module.gcp_node_pool.google_container_node_pool.node_pools[2], but we are tolerating it because it is using the legacy plugin SDK.
    The following problems may be the cause of any confusing errors from downstream operations:
      - .management[0].auto_repair: planned value cty.False does not match config value cty.NullVal(cty.Bool)
      - .node_config[0].preemptible: planned value cty.False does not match config value cty.NullVal(cty.Bool)
      - .node_config[0].taint[1].effect: planned value cty.NullVal(cty.String) does not match config value cty.StringVal("NO_SCHEDULE")
      - .node_config[0].taint[1].key: planned value cty.NullVal(cty.String) does not match config value cty.StringVal("nvidia.com/gpu")
      - .node_config[0].taint[1].value: planned value cty.NullVal(cty.String) does not match config value cty.StringVal("present")

Panic Output

Expected Behavior

+ taint {
     + effect = "NO_SCHEDULE"
     + key    = "nvidia.com/gpu"
     + value  = "present"
}

Actual Behavior

+ taint {}

Steps to Reproduce

Apply the configuration defined above with:

  1. terraform apply

Important Factoids

it works for anything else in "key" field. Even "nvidia.com/gpu " "works", of course it is not valid later during api validation but at least this outpus looks right:

+ taint {
     + effect = "NO_SCHEDULE"
     + key    = "nvidia.com/gpu "
     + value  = "present"
}

References

I guess this one is related:

#2295

  • #0000
@ghost ghost added the bug label Sep 23, 2019
@rileykarson
Copy link
Collaborator

This will end up overlapping a lot with #4168, closing as a duplicate of that.

@ghost
Copy link

ghost commented Oct 24, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Oct 24, 2019
@github-actions github-actions bot added service/container forward/review In review; remove label to forward labels Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug forward/review In review; remove label to forward service/container
Projects
None yet
Development

No branches or pull requests

2 participants