Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting num_nodes for DEVELOPMENT clusters #4399

Closed
Legogris opened this issue Sep 4, 2019 · 2 comments
Closed

Allow setting num_nodes for DEVELOPMENT clusters #4399

Legogris opened this issue Sep 4, 2019 · 2 comments
Assignees
Labels

Comments

@Legogris
Copy link

Legogris commented Sep 4, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
  • If an issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to "hashibot", a community member has claimed the issue already.

Terraform Version

Terraform v0.11.14
+ provider.google v2.8.0

Affected Resource(s)

  • google_bigtable_instance

We have previously been able to use the same module for prod and development and templating in values for number of nodes, type, etc, that differs between environments. As of #2401 / GoogleCloudPlatform/magic-modules#679, we can no longer reuse templates in this way, so it is a breaking change for us (since we can't have fields optionally unset). I'd prefer being able to set num_nodes to 1 for development instances only.

Alternatively, make instance_type required to avoid the scenario motivating GoogleCloudPlatform/magic-modules#679

@ghost ghost added the bug label Sep 4, 2019
@rileykarson rileykarson self-assigned this Sep 4, 2019
@rileykarson
Copy link
Collaborator

Hey @Legogris!

You're correct that this was a breaking change- it was made as part of a major release, 2.0.0. num_nodes not being able to be set for DEVELOPMENT instances improves the validation of the resource, so I'm not sure it's a change I'd like to revert either. Additionally, this is solved entirely by using Terraform 0.12 instead of Terraform 0.11, where conditionally setting fields is possible.

Setting instance_type to Required would be another breaking change, so that's not really feasible.

@ghost
Copy link

ghost commented Oct 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants