Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_logging_metric linear_buckets width should allow float #4382

Closed
algermissen opened this issue Aug 31, 2019 · 2 comments
Closed

google_logging_metric linear_buckets width should allow float #4382

algermissen opened this issue Aug 31, 2019 · 2 comments
Assignees
Labels

Comments

@algermissen
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
  • If an issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to "hashibot", a community member has claimed the issue already.

Terraform Version

0.11.14

Affected Resource(s)

  • google_logging_metric

Terraform Configuration Files

resource "google_logging_metric" "dns_relay_queries_latency" {
  provider = "google-beta"
  project  = "xxxx"
  name     = "dns-relay/queries/latency"
  filter   = "resource.type=\"gce_instance\" AND logName=\"projects/xxxx/logs/gcplogs-docker-driver\""

  metric_descriptor {
    metric_kind = "DELTA"
    value_type  = "DISTRIBUTION"
  }

  value_extractor = "REGEXP_EXTRACT(jsonPayload.message, \" ([0-9.]+)s$\")"

  bucket_options {
    linear_buckets {
      num_finite_buckets = "20"
      width              = "0.1"
      offset             = "0"
    }
  }
}

Debug Output

Panic Output

Expected Behavior

Floating point numbers should be supported. At least in the Stackdriver UI I can enter a float. It is also the only way to deal with values < 1 in the distribution usefully.

Actual Behavior

Error: google_logging_metric.dns_relay_queries_latency: bucket_options.0.linear_buckets.0.width: cannot parse '' as int: strconv.ParseInt: parsing "0.1": invalid syntax

Steps to Reproduce

  1. terraform apply

Important Factoids

References

  • #0000
@ghost ghost added the bug label Aug 31, 2019
@rileykarson rileykarson self-assigned this Sep 3, 2019
@rileykarson rileykarson removed their assignment Oct 14, 2019
@edwardmedia edwardmedia self-assigned this Jan 8, 2020
@edwardmedia
Copy link
Contributor

@algermissen the width must be a whole number. There is a rule that validates the input. Also the version of the provider you used, I guess, is pretty old, as the syntax has changed. Please upgrade your version and try again. I am closing this issue. If you think you still need assistance on this issue, please reopen it. Thanks

@ghost
Copy link

ghost commented Feb 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Feb 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants