Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Service Accounts and IAM roles to Cloud Run #4262

Closed
mbrancato opened this issue Aug 15, 2019 · 6 comments · Fixed by GoogleCloudPlatform/magic-modules#2770
Closed
Assignees

Comments

@mbrancato
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Currently, the google_cloud_run_service resource cannot assign a service account, so all revisions run as the default compute service account which can be undesirable from a security perspective. My use-case here is I want to deploy an app with a service account specific to that app with only the IAM roles needed for things like storage and KMS access.

The IAM assignment is needed as this controls if a Cloud Run endpoint is accessible unauthenticated from the Internet or not.

New or Affected Resource(s)

  • google_cloud_run_service
  • google_cloud_run_service_iam_*

Potential Terraform Configuration

resource "google_cloud_run_service" "default" {
  name     = "app-name"
  location = "us-central1"

  metadata {
    namespace = "projectname"
  }

  spec {
    containers {
      image = "us.gcr.io/projectname/app:1.0"
    }
  }

  service_account {
    email  = "${google_service_account.app.email}"
    scopes = ["cloud-platform"]
  }
}

resource "google_cloud_run_service_iam_member" "invoker" {
  instance     = "app-name"
  role         = "roles/run.invoker"
  member       = "allUsers"
}

References

@ghost ghost added the enhancement label Aug 15, 2019
@rkettelerij
Copy link

Currently this prevents the use of Terraform to create Google Cloud Endpoints for Cloud Run. Since Cloud Endpoints with Cloud Run requires specifying an IAM policy (e.g. gcloud beta run services add-iam-policy-binding).

@dinvlad
Copy link

dinvlad commented Sep 16, 2019

A bit unrelated, but Cloud Function resources also don't seem to support IAM policy in TF.
EDIT: Correction, looks like this has been addressed in #4420

@joshua9519
Copy link

Is this something anyone can do? I have seen in the magic modules repo, there is a comment for the service account section of cloud run that this will be done by the cloud run people?
https://github.com/GoogleCloudPlatform/magic-modules/blob/0211126a3474b49e6f64172b0c6228f048b200c7/products/cloudrun/api.yaml#L454

@slevenick
Copy link
Collaborator

Going to be taking a look at adding the IAM policy and binding resources for this.

Adding service accounts to cloud run services was done via: GoogleCloudPlatform/magic-modules#2740

@slevenick
Copy link
Collaborator

slevenick commented Dec 5, 2019

Finished support for IAM resources for the Cloud Run Service resource. This will be available in the next release of the provider (3.2.0)

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants