Add support for Cloud Functions IAM, document private-by-default by 2019/11/01

[rileykarson]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

On Nov 1, 2019 Cloud Functions will go private by default. We should add IAM support and get users ready for the switch far in advance.

New or Affected Resource(s)

• google_cloudfunctions_function
• google_cloudfunctions_function_iam_*

[rileykarson]

This isn't technically a breaking change for Terraform, but it is from the API.

[jamiekt]

Hello @rileykarson , I see this issue is currently unassigned. Has there been any discussions pertaining to working on this issue?
Also interested to know if 15 thumbsups (which the issue currently has) is considered a significant enough number to warrant discussion or whether 1 is just a drop in the ocean?

[rileykarson]

We have nobody actively assigned yet, but we're aware of the severity of the issue and will ensure that we provide IAM support for a reasonable window before the API-side change.

[jamiekt]

Hi @rileykarson / @emilymye ,
We're 17 days away from cloud functions going private by default, just wondering if you know of any progress on this particular issue?

[rileykarson]

Ah- looks like we didn't close this issue out or link the appropriate PRs. Sorry about that! We've supported the appropriate IAM resources since 2.15.0, and put up the private-by-default documentation in 2.16.0.

GoogleCloudPlatform/magic-modules#2297 added support for IAM resources while GoogleCloudPlatform/magic-modules#2321 added the docs.

The correctly formatted example on this page shows how to create a public fn post-change: https://www.terraform.io/docs/providers/google/r/cloudfunctions_function.html

I'll put out a change fixing the formatting on the page.

[jamiekt]

fantastic, thanks @rileykarson

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!