Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_logging_project_exclusion missing percent to exclude option #3844

Closed
alexcurtin opened this issue Jun 12, 2019 · 2 comments
Closed

google_logging_project_exclusion missing percent to exclude option #3844

alexcurtin opened this issue Jun 12, 2019 · 2 comments

Comments

@alexcurtin
Copy link

alexcurtin commented Jun 12, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

The GCP Stack Driver Logging exclusion editor allows you to submit a filter and a percent to exclude of events, as documented here: https://cloud.google.com/logging/docs/exclusions#excluding-resource

Percent to Exclude: Enter an integer or floating-point value from 0 to 100. For example, enter 100 or 100.0 to exclude all matching log entries. Enter 99.50 to exclude 99.5% of the matching entries but keep 0.5% of them in Logging.

However, the terraform-provider-google does not have a field to allow for this configurable percent to exclude

New or Affected Resource(s)

google_logging_project_exclusion

Potential Terraform Configuration

resource "google_logging_project_exclusion" "my-exclusion" {
    name = "my-instance-debug-exclusion"

    description = "Exclude GCE instance debug logs"

    # Exclude all DEBUG or lower severity messages relating to instances
    filter      = "resource.type = gce_instance AND severity <= DEBUG"
   
    percent = 50
}

References

https://cloud.google.com/logging/docs/exclusions#excluding-resource
https://cloud.google.com/logging/docs/exclusions#exclusion-filters

@ghost ghost added the enhancement label Jun 12, 2019
@emilymye
Copy link
Contributor

emilymye commented Jun 12, 2019

Does the sample filter work for this?

Edit: I confirmed that the UI is just wrapping a call with filter set (NOT sample(operation.id, 0.5)). If you're not sure how to construct it, I'd recommend making it in the console first and viewing the filter string used to construct it.

I'm going to close this issue but feel free to reopen if you have questions!

@ghost
Copy link

ghost commented Jul 14, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants