Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search console domains #3827

Closed
jleclanche opened this issue Jun 10, 2019 · 4 comments
Closed

Search console domains #3827

jleclanche opened this issue Jun 10, 2019 · 4 comments

Comments

@jleclanche
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

There doesn't appear to be resources for the Google Search Console sites:
https://developers.google.com/webmaster-tools/search-console-api-original/v3/sites/add

Would these go in the google terraform provider or would it belong in a separate provider?

New or Affected Resource(s)

  • google_search_console_domain
  • google_search_console_site

Potential Terraform Configuration

resource "google_search_console_site" "https_example_com" {
    site_url = "https://example.com"
}

resource "google_search_console_domain" "example_com" {
    domain = "example.com"  # Maps to sc-domain:example.com
}

# Verification examples

resource "cloudflare_record" "example_com_google_verification" {
    domain = "example.com"
    name = "example.com"
    type = google_search_console_domain.example_com.dns_txt_verification.type
    value = google_search_console_domain.example_com.dns_txt_verification.value
}

# Outputs:
# google_search_console_domain.example_com.verification_tag = "google-site-verification"
# google_search_console_domain.example_com.verification_value = "<code>"
@ghost ghost added the enhancement label Jun 10, 2019
@jleclanche
Copy link
Author

I'm guessing these go in a separate provider as they're not really part of the same API as the rest?

@emilymye
Copy link
Contributor

My response is the same as aboves - the Google in terraform-google-provider actually means "Google Cloud", so we'd probably not fold it into this provider.

@jleclanche
Copy link
Author

@emilymye Thanks for the clarification. Is there an existing provider this better fits into or would this be a new one?

@ghost
Copy link

ghost commented Jul 11, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants