Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throttle organization search requests to cloudresourcemanager API #3483

Closed
rofuentes opened this issue Apr 23, 2019 · 1 comment · Fixed by GoogleCloudPlatform/magic-modules#2097
Labels

Comments

@rofuentes
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
  • If an issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to "hashibot", a community member has claimed the issue already.

Terraform Version

Any

Affected Resource(s)

google.golang.org/api/cloudresourcemanager/v1
google.golang.org/api/cloudresourcemanager/v2beta1

config.clientResourceManager.Organizations.Search

  • This would also apply to Folders.Search (v2beta1), but that API endpoint does not appear to be used.

Expected Behavior

  • Organizations.Search (and potentially Folders.Search) requests should be held to 7 in parallel
  • Client should handle 429 errors

Actual Behavior

  • More than 7 Organizations.Search requests may occur
  • Client does not handle 429 errors
  • #0000
@ghost
Copy link

ghost commented Sep 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant