Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GKE support for fuzzy version #2949

Closed
apetitbois opened this issue Jan 28, 2019 · 3 comments
Closed

GKE support for fuzzy version #2949

apetitbois opened this issue Jan 28, 2019 · 3 comments

Comments

@apetitbois
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Google keeps on bumping revision of available gke cluster version.
Their API supports a fuzzy logic to determine which version you want to build as seen in that link

Today, we want to be able to build consistently our cluster with the same major/minor versions of kube.
For example, I'd like to be able to specify building 1.11.6 and not 1.11.6-gke.5 which may or may not supported in a couple of days and break my pipelines.

New or Affected Resource(s)

google_container_cluster

Potential Terraform Configuration

resource "google_container_cluster" "controlPlane" {
    name               = "${var.cluster_name}"
    region             = "${var.cluster_region}"

    min_master_version = "1.11.5-gke.5"
[...]
}
resource "google_container_cluster" "controlPlane115" {
    name               = "${var.cluster_name}"
    region             = "${var.cluster_region}"

    min_master_version = "1.11.5"
[...]
}

resource "google_container_cluster" "controlPlaneLatest" {
    name               = "${var.cluster_name}"
    region             = "${var.cluster_region}"

    min_master_version = "latest"
[...]
}

References

https://cloud.google.com/kubernetes-engine/versioning-and-upgrades#specifying_cluster_version

@ghost ghost added the enhancement label Jan 28, 2019
@petervandenabeele
Copy link

Just to make sure, is this not already working for min_master_version?

min_master_version = "1.11.6" works for me. I changed it from the 1.11.N-gke.M style like 2 months ago.

For node version, I do keep the "1.11.6-gke.2" style.

@apetitbois
Copy link
Author

You are correct, I was mistaken and the error message was indeed coming from my node pool and not from my control plane.

I'll close this issue as I'm now buliding my nodepools with version = "{....controlPlane.master_version}"

@ghost
Copy link

ghost commented Mar 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants