Allow redis_instance to infer region from location_id

[rsalmond]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Allow google_redis_instance to infer the region parameter when location_id is specified.

New or Affected Resource(s)

• google_redis_instance

Potential Terraform Configuration

resource "google_redis_instance" "my_redis" {
  name               = "my_redis"
  memory_size_gb     = 1
  tier               = "BASIC"
  location_id        = "us-central1-b"
}

Details

At present, when no region or zone is specified at the provider level, the above code produces the following error.

Error: Error applying plan:

1 error(s) occurred:

* google_redis_instance.my_redis: Cannot determine region: set in this resource, or set provider-level 'region' or 'zone'.

[danawillow]

relabeling this as a bug since it appears on first glance that the location_id field is completely ignored in favor of region, which shouldn't be the case if that's true.

[danawillow]

Changed my mind; not a bug since in the API, locationId is always a zone but you have to specify a region on create.

Let's say I specify us-central1 at the provider level and us-west1-b (but no explicit region) at the instance level. Should the instance create in us-west1 because I put that as my location id, or should it error because we took the region from the provider? The first one makes more sense just thinking about this resource individually, but the second makes more sense thinking about the provider as a whole and how we tend to fall back to getting the region from the provider when none is specified in a config.

[atmatthewat]

Possibly related to my #3690 - If you set the provider region to a zone (vs. unset as per this bug), you get even more confusing error messages

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!