Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add force_destroy field for google_dns_managed_zone #2305

Closed
ensonic opened this issue Oct 23, 2018 · 3 comments
Closed

Add force_destroy field for google_dns_managed_zone #2305

ensonic opened this issue Oct 23, 2018 · 3 comments

Comments

@ensonic
Copy link

ensonic commented Oct 23, 2018

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Currently we need to write out own script to flush a managed zone before deletion:
https://gist.github.com/ensonic/78cd078e806cd2592a62b0e7994b0e8d

Similarly to the google_storage_bucket resource, we should have a force_destroy flag that we can set to delete all entries on destroy.

New or Affected Resource(s)

  • google_dns_managed_zone

Potential Terraform Configuration

resource "google_dns_managed_zone" "my-dns-zone" {
  name = "my-dns-zone"
  dns_name = "${var.domain}."
  description = "...."
  depends_on = ["google_project_service.dns"]
  force_destroy = true
}

References

@ensonic
Copy link
Author

ensonic commented Oct 23, 2018

If you agree that this is the way to go an maybe provide some pointers I can try to make a PR.

@danawillow
Copy link
Contributor

Closing as a duplicate of #1572

@ghost
Copy link

ghost commented Jun 14, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants