Always set self_link in state for instance_templates

[paddycarver]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

We're currently setting a variety of different outputs (whatever resolveImage returns) in the source_image field for instance_templates. We've fixed the bugs around this, but we should take the chance for a breaking change to get a consistent output, if possible. It's probably worth checking that there are no unwanted side-effects or loss of possibilities if we just always return self_link from resolveImage.

New or Affected Resource(s)

• google_compute_instance_template
• google_compute_instance
• google_compute_instance_from_tempalte
• google_compute_region_disk
• google_compute_disk

References

• Fix perma-diff on instance templates. #1995

[paddycarver]

I believe this was resolved with #2153?

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!