Custom app_engine feature_settings in google_project requires two applys

[lilithmooncohen]

In order to set custom feature settings in the new google_project app_engine block requires two terraform applys. This is not optimal.

Affected Resource(s)

• google_project

Terraform Configuration Files

locals {
  credentials_file_path = "./sa-key.json"
}

provider "google" {
  credentials = "${file(local.credentials_file_path)}"
}

resource "google_project" "project" {
  name            = "testproject"
  project_id      = "testproject-11399"
  org_id          = "############"
  billing_account = "######-######-######"

  app_engine = [
    {
      location_id = "us-east1"

      feature_settings = [
        {
          split_health_checks = false
        },
      ]
    },
  ]
}

Expected Behavior

All app_engine settings configured in one terraform apply

Actual Behavior

Requires two passes of terraform apply to get everything set properly

Steps to Reproduce

Please list the steps required to reproduce the issue, for example:

1. Set feature_settings in app_engine block
2. terraform apply
3. terraform plan to see additional work needed
4. terraform apply
   See gist for full output: https://gist.github.com/ryanckoch/ab3e3780071f1fb6f8616402890e0af4

[nat-henderson]

Well, that's not great! I'll see if I can get that added to our unit tests so we don't continue to regress. Thanks!

[nat-henderson]

Hm, interesting - it looks like it's already in our unit tests, and in fact we don't get the same results. It works with only one apply. Can you post debug logs?

[lilithmooncohen]

@ndmckinley Debug output here: https://gist.github.com/ryanckoch/297af803a3c6fe161528d016fc6e872f#file-issue-1826-debug-txt

[nat-henderson]

Very strange, but yes, I see the error right there. What version of the Google provider are you using? I can't repro in 0.16.2.

[lilithmooncohen]

Hmmm

➜  terraform --version
Terraform v0.11.7
+ provider.google (unversioned)

Your version of Terraform is out of date! The latest version
is 0.11.8. You can update by downloading from www.terraform.io/downloads.html

➜  bash -c "cd ${GOPATH}/src/github.com/DeviaVir/terraform-provider-gsuite && git rev-parse HEAD"
1ece8af5a8acc4aac3639652bd602eddb63ad7f4

[nat-henderson]

Sorry, it's terraform-provider-google, not terraform-provider-gsuite. :(

[lilithmooncohen]

Bah... Sorry... I clearly need a nap

➜  issue-1826 bash -c "cd ${GOPATH}/src/github.com/terraform-providers/terraform-provider-google && git rev-parse HEAD"
f3fa40caf2bbc303dcca23ae15eabc1dc5716067

[nat-henderson]

That's all right! That's a commit from mid-last month, and there have been several fixes to app engine since then - odds are good that an upgrade will resolve your issue.

[rileykarson]

This field was removed and split out into a separate resource; see https://www.terraform.io/docs/providers/google/version_2_upgrade.html#app_engine-has-been-removed

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!