Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing instance_ip_mode argument to the network section of google_app_engine_flexible_app_version resource (Beta-only field) #17510

Open
gwendal-lecren opened this issue Mar 7, 2024 · 3 comments

Comments

@gwendal-lecren
Copy link

gwendal-lecren commented Mar 7, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to a user, that user is claiming responsibility for the issue.
  • Customers working with a Google Technical Account Manager or Customer Engineer can ask them to reach out internally to expedite investigation and resolution of this issue.

Description

The instance_ip_mode attribute from the network section is missing.
This attribute basically allow to prevent instances from receiving an ephemeral external IP address:
https://cloud.google.com/appengine/docs/flexible/reference/app-yaml?tab=python#network_settings

New or Affected Resource(s)

  • google_app_engine_flexible_app_version

Potential Terraform Configuration

resource "google_app_engine_flexible_app_version" "app" {
  ...
  network {
    name             = var.network
    subnetwork       = var.subnetwork
    session_affinity = true
    # Could be `internal` or `external` according to the documentation
    instance_ip_mode = "internal"
  }
  ...
}

References

This field is present in the Beta version of the API : https://cloud.google.com/appengine/docs/admin-api/reference/rest/v1beta/apps.services.versions#network

b/328654356

@github-actions github-actions bot added forward/review In review; remove label to forward service/appengine labels Mar 7, 2024
@trodge trodge removed the forward/review In review; remove label to forward label Mar 7, 2024
@SarahFrench
Copy link
Member

Hi @gwendal-lecren, thanks for opening this issue! I took a look at the API that the google_app_engine_flexible_app_version resource maps to and I can't see a field for setting instance IP mode under network. Features that are available in gcloud aren't always available to the Terraform provider via the public APIs, or it may be that the API docs are out of date. Have you been able to set this field when using the AppEngine API directly?

@SarahFrench SarahFrench self-assigned this Mar 11, 2024
@gwendal-lecren
Copy link
Author

@SarahFrench
Copy link
Member

Ah, thanks! Then yes we'd add this as a field in the beta provider. I'll update the issue to flag that to the service team this issue has been forwarded to

@SarahFrench SarahFrench changed the title google_app_engine_flexible_app_version is missing instance_ip_mode attribute in network section Add missing instance_ip_mode argument to the network section of google_app_engine_flexible_app_version resource (Beta-only field) Mar 11, 2024
@SarahFrench SarahFrench added this to the Goals milestone Mar 11, 2024
@SarahFrench SarahFrench removed their assignment Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants