Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TeamCity: Add GHAs to run the TeamCity configuration's tests on PRs editing the TeamCity configuration #17231

Closed
SarahFrench opened this issue Feb 9, 2024 · 2 comments · Fixed by GoogleCloudPlatform/magic-modules#9954

Comments

@SarahFrench
Copy link
Member

Background

There are automated tests for the TeamCity configuration but they can only be run locally by developers. We should automate running these tests to prevent bugs entering the code.

The Azure provider has pre-existing GHAs for running TeamCity tests, so we can take a lot of inspiration from them:

We should make this GHA run on PRs where files in mmv1/third_party/terraform/.teamcity are edited.

What kind of contribution is this issue about?

  • Contribution to the TeamCity config

Related PR(s), if any:

Details

We don't need to generate the downstream provider to run these tests - we can run them directly in mmv1/third_party/terraform/.teamcity. This will continue to be true as long as those files aren't compiled (currently they're all copied unchanged into the TPG repo, and not TPGB).

@SarahFrench
Copy link
Member Author

SarahFrench commented Feb 9, 2024

This issue is like a cousin of #17168, but neither blocks the other.

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.