cloudbuild_trigger should support build.tags

[magiconair]

Terraform Version

Terraform v0.11.7
+ provider.google v1.14.0

Affected Resource(s)

Please list the resources as a list, for example:

• google_cloudbuild_trigger

Terraform Configuration Files

resource "google_cloudbuild_trigger" "my-client" {
  project     = "${var.project_id}"
  description = "Build my-client"
  filename    = "cloudbuild-client.yaml"
  trigger_template {
    project   = "${var.project_id}"
    repo_name = "github-client"
    tag_name  = "v\\d.*"
  }
  build {
    tags = ["my-client"]
  }
}

Expected Behavior

build.tags should be permitted.

Actual Behavior

Error: google_cloudbuild_trigger.my-client: "filename": conflicts with build ([]map[string]interface {}{map[string]interface {}{"tags":[]interface {}{"my-client"}}})

Steps to Reproduce

1. terraform plan

References

Are there any other GitHub issues (open or closed) or Pull Requests that should be linked here? For example:

• Support filename field for cloudbuild_trigger resource #1591
• Allow using in repo configuration for cloudbuild trigger #1557

I have tried this but that didn't have the desired effect:

diff --git a/google/resource_cloudbuild_build_trigger.go b/google/resource_cloudbuild_build_trigger.go
index 278e803..b952ef9 100644
--- a/google/resource_cloudbuild_build_trigger.go
+++ b/google/resource_cloudbuild_build_trigger.go
@@ -40,7 +40,7 @@ func resourceCloudBuildTrigger() *schema.Resource {
                                Type:          schema.TypeString,
                                Optional:      true,
                                ForceNew:      true,
-                               ConflictsWith: []string{"build"},
+                               ConflictsWith: []string{"build.step", "build.images"},
                        },
                        "build": {
                                Type:        schema.TypeList,

[magiconair]

Actually, that is wrong since the tags are specified in the cloudbuild.yaml file.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!