Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The corresponding magic-modules commit should be programmatically identified based of the TPG commit #14609

Closed

Comments

@maqiuyujoyce
Copy link

Background

Right now, it's a completely manual process with several steps to find the corresponding magic-modules commit based on the TPG commit/release. E.g. here is an example process @rileykarson described based on v4.65.0:

Start from a release like https://github.com/hashicorp/terraform-provider-google-beta/releases/tag/v4.65.0 and find the merge-base between its commit (hashicorp/terraform-provider-google-beta@2d27c83) and main (i.e. the branching point). That's hashicorp/terraform-provider-google-beta@729b518 here. Then open the PR that added it (hashicorp/terraform-provider-google-beta#5618), click the derived from button (GoogleCloudPlatform/magic-modules#7875), and then find the squashed commit: GoogleCloudPlatform/magic-modules@1d360b4

Would be great if the corresponding magic-modules commit can be programmatically identified based of the TPG commit.

What kind of contribution is this issue about?

  • general contributions

Related PR(s), if any:

N/A

Details

See background.

@rileykarson
Copy link
Collaborator

If we do this in the generator as part of the sync job, we should be able to add the MM commit to the PR description (and therefore commit description) in TPG/TPGB

Copy link

github-actions bot commented Nov 2, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.