Error when deleting bigquery_dataset_access and modifying bigquery_dataset in same apply

[roaks3]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
• Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.
• If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Affected Resource(s)

• google_bigquery_dataset
• google_bigquery_dataset_access

Terraform Configuration Files

Step 1:

resource "google_bigquery_dataset" "public" {
  dataset_id  = "%{public_dataset}"
  description = "This dataset is public"
}

resource "google_bigquery_routine" "public" {
  dataset_id      = google_bigquery_dataset.public.dataset_id
  routine_id      = "%{public_routine}"
  routine_type    = "TABLE_VALUED_FUNCTION"
  language        = "SQL"
  definition_body = <<-EOS
    SELECT 1 + value AS value
  EOS
  arguments {
    name          = "value"
    argument_kind = "FIXED_TYPE"
    data_type     = jsonencode({ "typeKind" = "INT64" })
  }
  return_table_type = jsonencode({ "columns" = [
    { "name" = "value", "type" = { "typeKind" = "INT64" } },
  ] })
}

resource "google_bigquery_dataset" "private" {
  dataset_id  = "%{private_dataset}"
  description = "This dataset is private"
}

resource "google_bigquery_dataset_access" "authorized_routine" {
  dataset_id = google_bigquery_dataset.private.dataset_id
  routine {
    project_id = google_bigquery_routine.public.project
    dataset_id = google_bigquery_routine.public.dataset_id
    routine_id = google_bigquery_routine.public.routine_id
  }
}

Step 2:

resource "google_bigquery_dataset" "private" {
  dataset_id  = "%{private_dataset}"
}

Debug Output

Error: Error updating Dataset "projects/ci-test-project-188019/datasets/tf_test_private_dataset_wrfzzyl3d7": googleapi: Error 400: Routine ci-test-project-188019:tf_test_public_dataset_dcbf92qyze.tf_test_public_routine_td7oeldldh to authorize not found., invalid

Panic Output

Expected Behavior

The Step 2 config should be applied as expected

Actual Behavior

The Step 2 config fails to update the private dataset with the error above. However, a subsequent apply does resolve the issue.

Steps to Reproduce

1. terraform apply with Step 1 config
2. terraform apply with Step 2 config

Important Factoids

This error came out of a test failure we saw #13023. Since this particular issue can be resolve with an additional apply, this specific problem seems less critical. However, there seems to be an underlying issue where the bigquery_dataset and bigquery_dataset_access cannot both be modified in the same apply, or they will compete for control over the access configuration. We are adding a note to the docs, but long-term if we see similar issues, we should fix this so that it doesn't error (possibly using a PATCH call instead of a PUT for bigquery_dataset updates).

References

• Failing test(s): TestAccBigQueryDatasetAccess_authorizedRoutine #13023

b/299601059