Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation around timeout_sec argument for LB Backend needs update / clarification #13587

Closed
jeheyer opened this issue Jan 27, 2023 · 4 comments

Comments

@jeheyer
Copy link

jeheyer commented Jan 27, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

1.3.4

Affected Resource(s)

  • google_compute_backend_service
  • google_compute_region_backend_service

Terraform Configuration Files

resource "google_compute_backend_service" "default" {
  timeout_sec           = 86401
}

Debug Output

n/a

Panic Output

n/a

Expected Behavior

Value should be rejected since it falls outside documented range of 1-86400 (1 day)

Actual Behavior

Value is accepted as it's well within Google accepted max of 2^31 - 1 seconds.

Steps to Reproduce

  1. terraform apply

Important Factoids

Just looks like a documentation update that's needed.

In addition to the max value, it would be extremely useful to mention that this value sets the max request / response time for HTTP(S) load balancers, but acts as an idle timeout value for TCP and SSL Proxies. The setting is completely ignored for internal TCP/UDP load balancers. Google mentions this in the gCloud documentation, but doesn't make the distinction when using the Web UI which I suspect is causing some confusion.

References

  • #0000

b/317497334

@jeheyer jeheyer added the bug label Jan 27, 2023
@rileykarson rileykarson removed the bug label Mar 6, 2023
@rileykarson rileykarson added this to the Goals milestone Mar 20, 2023
@github-actions github-actions bot added forward/review In review; remove label to forward service/compute-l7-load-balancer labels Oct 25, 2023
@melinath
Copy link
Collaborator

This looks like a simple docs update for timeoutSec - the API docs for the resource have the correct value.

@pawelJas
Copy link

@melinath Docs have been updated. Could you close this issue, please?

@melinath
Copy link
Collaborator

Closed by #18400

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants