Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tpgtools only supports string -> string maps #13469

Closed
molerus opened this issue Jan 12, 2023 · 4 comments
Closed

tpgtools only supports string -> string maps #13469

molerus opened this issue Jan 12, 2023 · 4 comments
Assignees
Labels
enhancement service/terraform size/xl tpgtools Issues related to the tpgtools generator
Milestone

Comments

@molerus
Copy link

molerus commented Jan 12, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Magic modules generators only support maps where both the key and the value are strings. There is an existing TODO to change it.

New or Affected Resource(s)

  • google_vmwareengine_private_cloud
  • google_vmwareengine_cluster

References

https://github.com/GoogleCloudPlatform/magic-modules/blob/c2608fa90cc696a0ed426626334e7ee5467d87dc/tpgtools/templates/serialization.go.tmpl#L164

@melinath melinath added mmv1-generator Provider-wide changes to resource templates or other generator changes tpgtools Issues related to the tpgtools generator size/xl labels Jan 17, 2023
@melinath melinath added this to the Goals milestone Jan 17, 2023
@github-actions github-actions bot added forward/review In review; remove label to forward service/vmwareengine labels Aug 17, 2023
@melinath
Copy link
Collaborator

melinath commented Sep 7, 2023

I'm not entirely sure whether this would be possible to do; Terraform maps are string -> string only. But we could possibly approximate something? We'd need at least one example of a field that needs this behavior.

@melinath melinath added service/terraform and removed tpgtools Issues related to the tpgtools generator forward/review In review; remove label to forward service/vmwareengine labels Sep 7, 2023
@rileykarson
Copy link
Collaborator

@slevenick you fixed this, right?

@rileykarson rileykarson added tpgtools Issues related to the tpgtools generator and removed mmv1-generator Provider-wide changes to resource templates or other generator changes labels Mar 28, 2024
@rileykarson rileykarson changed the title Magic modules only supports string -> string maps tpgtools only supports string -> string maps Mar 28, 2024
@slevenick
Copy link
Collaborator

Yes, this was fixed in GoogleCloudPlatform/magic-modules#10039.

Use of this feature requires a per-map override that sets the key name. See https://github.com/GoogleCloudPlatform/magic-modules/pull/10039/files#diff-dbbb52ee94ecce1ab59369bd8fcf3b283625728bd72738df2e13ef400c8185dfR28 for reference

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement service/terraform size/xl tpgtools Issues related to the tpgtools generator
Projects
None yet
Development

No branches or pull requests

4 participants