Add validation for resource names

[natedogith1]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Resource names should be validated during a plan. Searching the repo for "validateGCEName" finds 19 resources that currently do this.

New or Affected Resource(s)

• google_compute_disk
• google_compute_health_check
• probably many others

References

• No validation for google_compute_network resource name #9113

[rileykarson]

Duplicate of #3580

[natedogith1]

I didn't notice #3580. Should I open a separate issue for each resource that doesn't have its name validated? (or just one for each naming convention, for instance all compute engine resource apparently have the same format: https://cloud.google.com/compute/docs/naming-resources#resource-name-format)

[rileykarson]

If there are specific resources where you think the additional validation is valuable, please feel free! A general validation backfill isn't something our team is interested in at the moment, however.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.