Delete protection to Notebooks Instance

[marino-serna]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

A notebook is a resource that may contain useful information, and is important to provide a protection to avoid deletions by mistake

As some fields cannot properly detect drifts, every time the project with “google_notebooks_instance” is deploy all the notebooks are delete and recreated, without any changes.

Include the deletion_protection option can reduce the hassle and avoid loss of data/work
If possible would be even better if the error message also specify what resource is requesting the deletion

New or Affected Resource(s)

• google_notebooks_instance

Potential Terraform Configuration

resource "google_notebooks_instance" "instance" {
  name = "notebooks-instance"
  location = "us-west1-a"
  machine_type = "e2-medium"
  deletion_protection = true
  vm_image {
    project      = "deeplearning-platform-release"
    image_family = "tf-latest-cpu"
  }
}

[DrFaust92]

unless this is provider only feature, its an upstream issue as the api doesnt have such an option. to prevent complete data loss you can use no_remove_data_disk

[marino-serna]

You are right DrFaust92, that is enough to solve most of the problem.

The policies will not remain as they are removed and cannot be added with the deployment:
#11795
but for my current situation is not that urgent. Hopefully the issue 11795 gets solved. I will choose this one.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.