Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_cloudbuild_trigger fails with HTTP Error 400 when git_file_source is used #11335

Closed
kawofong opened this issue Mar 23, 2022 · 4 comments
Closed
Labels

Comments

@kawofong
Copy link

kawofong commented Mar 23, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Terraform v1.1.7
on darwin_amd64
+ provider registry.terraform.io/hashicorp/google v4.15.0
+ provider registry.terraform.io/hashicorp/google-beta v4.15.0

Affected Resource(s)

  • google_cloudbuild_trigger

Terraform Configuration Files

resource "google_cloudbuild_trigger" "helloworld_ci_trigger" {
  name            = "helloworld-ci-trigger"
  description     = "Continuous integration for helloworld component"
  service_account = var.deploy_sa_email

  github {
    owner = "XXXXXX"
    name  = "XXXXXX"
    push {
      branch = "^main$"
    }
  }

  git_file_source {
    path      = "helloworld/cloudbuild_ci.yaml"
    repo_type = "GITHUB"
    uri       = "https://github.com/XXXXXX/XXXXXX"
  }

  included_files = ["helloworld/**"]

  substitutions = {
    _ARTIFACT_REGISTRY_REPO = "my-repository"
  }
}

Debug Output

https://gist.github.com/kawo123/ff3f3d60bdf8fb954616a5df6e564b57

Panic Output

Expected Behavior

The google_cloudbuild_trigger should be created with reference to cloudbuild configuration from GitHub repo.

Actual Behavior

I receive an error Error: Error creating Trigger: googleapi: Error 400: Request contains an invalid argument.

Steps to Reproduce

  1. terraform apply
@kawofong kawofong added the bug label Mar 23, 2022
@slevenick
Copy link
Collaborator

It looks like you don't have a repository specified in the configuration for the git_file_source? I'm guessing that there is default behavior but it is not finding the correct repository.

Can you try specifying the uri field in the git_file_source block and see if that resolves the issue? I'm guessing that the error message is very unspecific and should actually say that it cannot find the correct yaml file

@kawofong
Copy link
Author

@slevenick: Thanks for the suggestion. I updated the git_file_source block to include uri but still getting the same error Error 400: Request contains an invalid argument.

  git_file_source {
    path      = "helloworld/cloudbuild_ci.yaml"
    repo_type = "GITHUB"
    uri       = "https://github.com/XXXXXX/XXXXXX"
  }

@kawofong
Copy link
Author

Closing. Found the issue to be irrelevant to the git_file_source block thanks to @slevenick's help.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants