Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force downstream builder to wait for all sync branches before continuing #11109

Closed
c2thorn opened this issue Feb 14, 2022 · 2 comments · Fixed by GoogleCloudPlatform/magic-modules#10622
Assignees
Labels
fixit-technical-debt magician Issues and features related to our bespoke CI size/m technical-debt
Milestone

Comments

@c2thorn
Copy link
Collaborator

c2thorn commented Feb 14, 2022

Currently, sync steps wait on their individual sync branches before pushing new commits. We could create a prerequisite step that requires all sync branches to be synced before pushing any of them.

Doing so would remove the possibility of Divergence by more than one commit scenario. This is the most complicated scenario to resolve.

@melinath
Copy link
Collaborator

melinath commented Feb 16, 2024

Alternatively we could make it so that syncing "succeeds" automatically if the sync point is behind main - that is, we could make it possibly to retry runs without resetting all the sync branches. This would reduce the complexity of resolving the issue significantly by allowing one branch to catch up just by re-running jobs on Cloud Build rather than taking manual steps. this is covered by #12360 and is a separate consideration regardless of whether we force downstream builder to wait.

Copy link

github-actions bot commented Jun 9, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixit-technical-debt magician Issues and features related to our bespoke CI size/m technical-debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants