Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bfd to google_compute_router_peer #10554

Closed
ccschmid9 opened this issue Nov 15, 2021 · 2 comments
Closed

add bfd to google_compute_router_peer #10554

ccschmid9 opened this issue Nov 15, 2021 · 2 comments

Comments

@ccschmid9
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

It doesn't appear bfd can be configured with google_comput_router_peer.

The enhancement would be useful since Google's default for bfd is Disabled. Bfd should be used for optimal routing convergence in a highly available bgp environment.

New or Affected Resource(s)

  • google_compute_router_peer
  • bfd (optional)

Potential Terraform Configuration

# Propose what you think the configuration to take advantage of this feature should look like.
# We may not use it verbatim, but it's helpful in understanding your intent.
resource "google_compute_router_peer" "peer" {
  name                      = "my-router-peer"
  router                    = "my-router"
  region                    = "us-central1"
  peer_ip_address           = "169.254.1.2"
  peer_asn                  = 65513
  advertised_route_priority = 100
  interface                 = "interface-1"
  bfd                       = {
    session_initialization_mode = enum
    min_transmit_interval       = integer
    min_receive_interval        = integer
    multiplier                  = integer
  }
}

References

https://cloud.google.com/compute/docs/reference/rest/v1/routers
https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/compute_router_peer

  • #0000
@rileykarson rileykarson added this to the Goals milestone Nov 15, 2021
@c2thorn
Copy link
Collaborator

c2thorn commented Nov 15, 2021

added in #10487

@c2thorn c2thorn closed this as completed Nov 15, 2021
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants