Support Spot VMs

[balboah]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

I'm using preemtible instances today together with GKE autoscaling.
Just received the announcement from Google Cloud that they are switching to "Spot VMs".

I believe this feature should be added in the beta provider until GA.

New or Affected Resource(s)

• google_container_node_pool
• google_compute_instance

Potential Terraform Configuration

resource "google_container_node_pool" "primary_spotvm_nodes" {
  # ...

  node_config {
    spot  = true
    # ...
  }
}

References

• https://cloud.google.com/kubernetes-engine/docs/concepts/spot-vms
• Internal issue: http://b/202997221

[matthew-muscat]

Suggest that the potential terraform configuration for the instance is housed within the scheduling block (similar to where the preemptiable flag is)

resource "google_compute_instance" "instance" {
  name = "instance"
  #...

  scheduling {
    provisioning_model = SPOT
  }
}

Docs from gcloud beta cli...

 --provisioning-model=PROVISIONING_MODEL
    Specifies provisioning model, which determines price, obtainability,
    and runtime for the VM instance. PROVISIONING_MODEL must be (currently
    only one value is supported):

     SPOT
        Spot VM instances are preemptible VM instances without a 24-hour
        limit. They typically cost much less than a default VM, but have no
        guaranteed runtime.

[michal-kaciuba]

Hi, any estimate on release date for this feature?

[scotte]

Hi, any estimate on release date for this feature?

@MKaciuba It's available now in the "google-beta" provider. I used it yesterday. Since Google considers spot instances to be preview status, perhaps Terraform won't release it to the "google" provider until Google considers it GA? Just speculation, I have no idea...

[azmng]

Hi, any news regarding GCE support? I mean google_compute_instance and google_compute_instance_template resources, is there any plans to implement spot vms support?

[ShaunHowell]

Hi, the provisioning_model field is in the docs under beta but isn't actually included in the 4.11.0 release (link). It looks like this commit reverted its inclusion.
Was this an accident? Will this be re-included soon?

[lbg-raghu-vennam]

I just tried provisioning a spot instance and it worked with 4.13.0 provider version.

[rileykarson]

I'm not sure why this would have been in the [email protected], as it was in the release notes for https://github.com/hashicorp/terraform-provider-google-beta/releases/tag/v4.12.0. There may have been a minor hiccup- sorry about that!

I believe this issue is ready to be closed based on GoogleCloudPlatform/magic-modules#5662. @shuyama1 or @andrewyz please correct me if you feel otherwise! I see the PR says "part of" rather than "closes" which generally means a change only partially addresses an issue, but that's an unspoken meaning and I can't spot anything missing.

[andrewyz]

There were some test failures in 4.11.0 (We started the release process and the API is changed after then, which causes some tests to fail). And then we submit a patch to fix it but can't catch up the time. So the commit was reverted and then released in 4.12.0. Not sure why the [email protected] didn't reflect this change.

[rileykarson]

Hmm- the docs appear to have been properly reverted (we've reverted the code and not the docs in the past, so I figured I'd check that!). @megan07 is there a way to check the registry's commit/tag for past versions? This probably isn't worth spending much time on since it's correct in latest, but I'm curious 🤷

@andrewyz can you confirm that we can close this issue now?

[andrewyz]

Yes, looks good so far.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.