Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sourceToBuild block to google_cloudbuild_trigger #10211

Closed
pdfrod opened this issue Oct 1, 2021 · 2 comments
Closed

Add sourceToBuild block to google_cloudbuild_trigger #10211

pdfrod opened this issue Oct 1, 2021 · 2 comments

Comments

@pdfrod
Copy link

pdfrod commented Oct 1, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

The sourceToBuild block is currently not supported by the google_cloudbuild_trigger resource. This is necessary to be able to define webhook triggers.

New or Affected Resource(s)

  • google_cloudbuild_trigger

Potential Terraform Configuration

resource "google_cloudbuild_trigger" "build" {
  name     = "build"
  filename = "cloudbuild.yaml"

  webhook_config {
    secret = google_secret_manager_secret_version.build.id
  }

  # It would be nice to have a `source_to_build` block like this:
  source_to_build {
    uri      = "https://github.com/example/repo"
    ref      = "refs/heads/master"
    repoType = "GITHUB"
  }
}

References

@pdfrod
Copy link
Author

pdfrod commented Oct 1, 2021

Oops, just realized there's already an issue for this: #9883

Sorry for the spam.

@pdfrod pdfrod closed this as completed Oct 1, 2021
@github-actions
Copy link

github-actions bot commented Nov 1, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant