Skip to content

Commit

Permalink
Bring forwards/backwards compatible 0.12 syntax to HEAD (#408)
Browse files Browse the repository at this point in the history
<!-- This change is generated by MagicModules. -->
/cc @rileykarson
  • Loading branch information
modular-magician authored and rileykarson committed Feb 1, 2019
1 parent 7e71b70 commit 3c953a2
Show file tree
Hide file tree
Showing 15 changed files with 139 additions and 173 deletions.
5 changes: 1 addition & 4 deletions google-beta/data_source_google_compute_instance_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,7 @@ resource "google_compute_instance" "foo" {
metadata = {
foo = "bar"
baz = "qux"
}
metadata = {
startup-script = "echo Hello"
startup-script = "echo Hello"
}
labels = {
Expand Down
14 changes: 6 additions & 8 deletions google-beta/resource_cloudiot_registry_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -168,14 +168,12 @@ resource "google_cloudiot_registry" "foobar" {
mqtt_enabled_state = "MQTT_DISABLED"
}
credentials = [
{
"public_key_certificate" = {
format = "X509_CERTIFICATE_PEM"
certificate = "${file("test-fixtures/rsa_cert.pem")}"
}
},
]
credentials {
"public_key_certificate" = {
format = "X509_CERTIFICATE_PEM"
certificate = "${file("test-fixtures/rsa_cert.pem")}"
}
}
}
`, acctest.RandString(10), acctest.RandString(10), registryName)
}
9 changes: 5 additions & 4 deletions google-beta/resource_cloudscheduler_job_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ resource "google_cloud_scheduler_job" "job" {
description = "test job"
schedule = "*/2 * * * *"
pubsub_target = {
pubsub_target {
topic_name = "projects/%s/topics/build-triggers"
data = "${base64encode("test")}"
}
Expand All @@ -151,13 +151,14 @@ resource "google_cloud_scheduler_job" "job" {
description = "test app engine job"
time_zone = "Europe/London"
app_engine_http_target = {
app_engine_http_target {
http_method = "POST"
app_engine_routing = {
app_engine_routing {
service = "web"
version = "prod"
instance = "my-instance-001"
}
relative_uri = "/ping"
}
}
Expand All @@ -174,7 +175,7 @@ resource "google_cloud_scheduler_job" "job" {
schedule = "*/8 * * * *"
time_zone = "America/New_York"
http_target = {
http_target {
http_method = "POST"
uri = "https://example.com/ping"
}
Expand Down
17 changes: 10 additions & 7 deletions google-beta/resource_container_cluster_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1782,6 +1782,7 @@ resource "google_container_cluster" "with_network_policy_enabled" {
enabled = true
provider = "CALICO"
}
addons_config {
network_policy_config {
disabled = false
Expand All @@ -1808,7 +1809,7 @@ resource "google_container_cluster" "with_network_policy_enabled" {
initial_node_count = 1
remove_default_node_pool = true
network_policy = {}
network_policy {}
}`, clusterName)
}

Expand All @@ -1820,7 +1821,8 @@ resource "google_container_cluster" "with_network_policy_enabled" {
initial_node_count = 1
remove_default_node_pool = true
network_policy = {}
network_policy {}
addons_config {
network_policy_config {
disabled = true
Expand Down Expand Up @@ -1883,15 +1885,13 @@ func testAccContainerCluster_withMasterAuthorizedNetworksConfig(clusterName stri
cidrBlocks := emptyValue
if len(cidrs) > 0 {
var buf bytes.Buffer
buf.WriteString("cidr_blocks = [")
for _, c := range cidrs {
buf.WriteString(fmt.Sprintf(`
{
cidr_blocks {
cidr_block = "%s"
display_name = "disp-%s"
},`, c, c))
}`, c, c))
}
buf.WriteString("]")
cidrBlocks = buf.String()
}

Expand Down Expand Up @@ -2035,7 +2035,10 @@ resource "google_container_cluster" "with_tpu" {
master_ipv4_cidr_block = "10.42.0.0/28"
}
master_authorized_networks_config { cidr_blocks = [] }
master_authorized_networks_config {
cidr_blocks = []
}
ip_allocation_policy {
cluster_secondary_range_name = "${google_compute_subnetwork.container_subnetwork.secondary_ip_range.0.range_name}"
services_secondary_range_name = "${google_compute_subnetwork.container_subnetwork.secondary_ip_range.1.range_name}"
Expand Down
16 changes: 10 additions & 6 deletions google-beta/resource_container_node_pool_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -899,14 +899,18 @@ resource "google_container_cluster" "cluster" {
node_version = "${data.google_container_engine_versions.central1c.latest_node_version}"
min_master_version = "${data.google_container_engine_versions.central1c.latest_master_version}"
}
resource "google_container_node_pool" "np_with_gpu" {
name = "tf-nodepool-test-%s"
zone = "us-central1-c"
cluster = "${google_container_cluster.cluster.name}"
initial_node_count = 1
node_config {
machine_type = "n1-standard-1"
disk_size_gb = 10
oauth_scopes = [
"https://www.googleapis.com/auth/devstorage.read_only",
"https://www.googleapis.com/auth/logging.write",
Expand All @@ -915,15 +919,15 @@ resource "google_container_node_pool" "np_with_gpu" {
"https://www.googleapis.com/auth/servicecontrol",
"https://www.googleapis.com/auth/trace.append"
]
preemptible = true
service_account = "default"
image_type = "COS"
guest_accelerator = [
{
type = "nvidia-tesla-k80"
count = 1
}
]
guest_accelerator {
type = "nvidia-tesla-k80"
count = 1
}
}
}`, acctest.RandString(10), acctest.RandString(10))
}
Expand Down
80 changes: 33 additions & 47 deletions google-beta/resource_google_folder_iam_policy_test.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package google

import (
"bytes"
"fmt"
"reflect"
"testing"
Expand All @@ -19,37 +18,6 @@ func TestAccFolderIamPolicy_basic(t *testing.T) {
org := getTestOrgFromEnv(t)
parent := "organizations/" + org

policy := &resourceManagerV2Beta1.Policy{
Bindings: []*resourceManagerV2Beta1.Binding{
{
Role: "roles/viewer",
Members: []string{
"user:[email protected]",
},
},
},
}

resource.Test(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
Providers: testAccProviders,
CheckDestroy: testAccCheckGoogleFolderIamPolicyDestroy,
Steps: []resource.TestStep{
{
Config: testAccFolderIamPolicy_basic(folderDisplayName, parent, policy),
Check: testAccCheckGoogleFolderIamPolicy("google_folder_iam_policy.test", policy),
},
},
})
}

func TestAccFolderIamPolicy_update(t *testing.T) {
t.Parallel()

folderDisplayName := "tf-test-" + acctest.RandString(10)
org := getTestOrgFromEnv(t)
parent := "organizations/" + org

policy1 := &resourceManagerV2Beta1.Policy{
Bindings: []*resourceManagerV2Beta1.Binding{
{
Expand Down Expand Up @@ -83,11 +51,11 @@ func TestAccFolderIamPolicy_update(t *testing.T) {
CheckDestroy: testAccCheckGoogleFolderIamPolicyDestroy,
Steps: []resource.TestStep{
{
Config: testAccFolderIamPolicy_basic(folderDisplayName, parent, policy1),
Config: testAccFolderIamPolicy_basic(folderDisplayName, parent, "roles/viewer", "user:[email protected]"),
Check: testAccCheckGoogleFolderIamPolicy("google_folder_iam_policy.test", policy1),
},
{
Config: testAccFolderIamPolicy_basic(folderDisplayName, parent, policy2),
Config: testAccFolderIamPolicy_basic2(folderDisplayName, parent, "roles/editor", "user:[email protected]", "roles/viewer", "user:[email protected]"),
Check: testAccCheckGoogleFolderIamPolicy("google_folder_iam_policy.test", policy2),
},
},
Expand Down Expand Up @@ -162,31 +130,49 @@ func testAccFolderExistingPolicy(org, fname string) resource.TestCheckFunc {
}
}

func testAccFolderIamPolicy_basic(folder, parent string, policy *resourceManagerV2Beta1.Policy) string {
var bindingBuffer bytes.Buffer
func testAccFolderIamPolicy_basic(folder, parent, role, member string) string {
return fmt.Sprintf(`
resource "google_folder" "permissiontest" {
display_name = "%s"
parent = "%s"
}
for _, binding := range policy.Bindings {
bindingBuffer.WriteString("binding {\n")
bindingBuffer.WriteString(fmt.Sprintf("role = \"%s\"\n", binding.Role))
bindingBuffer.WriteString(fmt.Sprintf("members = [\n"))
for _, member := range binding.Members {
bindingBuffer.WriteString(fmt.Sprintf("\"%s\",\n", member))
}
bindingBuffer.WriteString("]}\n")
}
data "google_iam_policy" "test" {
binding {
role = "%s"
members = ["%s"]
}
}
resource "google_folder_iam_policy" "test" {
folder = "${google_folder.permissiontest.name}"
policy_data = "${data.google_iam_policy.test.policy_data}"
}
`, folder, parent, role, member)
}

func testAccFolderIamPolicy_basic2(folder, parent, role, member, role2, member2 string) string {
return fmt.Sprintf(`
resource "google_folder" "permissiontest" {
display_name = "%s"
parent = "%s"
}
data "google_iam_policy" "test" {
%s
binding {
role = "%s"
members = ["%s"]
}
binding {
role = "%s"
members = ["%s"]
}
}
resource "google_folder_iam_policy" "test" {
folder = "${google_folder.permissiontest.name}"
policy_data = "${data.google_iam_policy.test.policy_data}"
}
`, folder, parent, bindingBuffer.String())
`, folder, parent, role, member, role2, member2)
}
76 changes: 32 additions & 44 deletions google-beta/resource_google_project_iam_policy_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -380,31 +380,25 @@ data "google_iam_policy" "admin" {
}
audit_config {
service = "cloudkms.googleapis.com"
audit_log_configs = [
{
log_type = "DATA_READ"
exempted_members = [
"user:[email protected]",
]
},
{
log_type = "DATA_WRITE"
}
]
audit_log_configs {
log_type = "DATA_READ"
exempted_members = ["user:[email protected]"]
}
audit_log_configs {
log_type = "DATA_WRITE"
}
}
audit_config {
service = "cloudsql.googleapis.com"
audit_log_configs = [
{
log_type = "DATA_READ"
exempted_members = [
"user:[email protected]",
]
},
{
log_type = "DATA_WRITE"
}
]
audit_log_configs {
log_type = "DATA_READ"
exempted_members = ["user:[email protected]"]
}
audit_log_configs {
log_type = "DATA_WRITE"
}
}
}
`, pid, name, org)
Expand Down Expand Up @@ -476,31 +470,25 @@ data "google_iam_policy" "expanded" {
}
audit_config {
service = "cloudkms.googleapis.com"
audit_log_configs = [
{
log_type = "DATA_READ"
exempted_members = [
"user:[email protected]",
]
},
{
log_type = "DATA_WRITE"
}
]
audit_log_configs {
log_type = "DATA_READ"
exempted_members = ["user:[email protected]"]
}
audit_log_configs {
log_type = "DATA_WRITE"
}
}
audit_config {
service = "cloudkms.googleapis.com"
audit_log_configs = [
{
log_type = "DATA_READ"
exempted_members = [
"user:[email protected]",
]
},
{
log_type = "ADMIN_READ"
}
]
audit_log_configs {
log_type = "DATA_READ"
exempted_members = ["user:[email protected]"]
}
audit_log_configs {
log_type = "DATA_WRITE"
}
}
}`, pid, name, org)
}
1 change: 0 additions & 1 deletion google-beta/resource_logging_organization_sink_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,6 @@ resource "google_logging_organization_sink" "update" {
org_id = "%s"
destination = "storage.googleapis.com/${google_storage_bucket.log-bucket.name}"
filter = "logName=\"projects/%s/logs/compute.googleapis.com%%2Factivity_log\" AND severity>=ERROR"
destination = "storage.googleapis.com/${google_storage_bucket.log-bucket.name}"
include_children = false
}
Expand Down
Loading

0 comments on commit 3c953a2

Please sign in to comment.