Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Storage account #169

Merged
merged 4 commits into from
Mar 18, 2022
Merged

Conversation

abner-dou
Copy link
Contributor

  • updated storage account resource and datasource

@@ -155,6 +156,11 @@ func storageAccountDataSource() *schema.Resource {
},

"tags": tags.SchemaDataSource(),

"enable_https_traffic_only": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we always put enabled on the end of the property

Suggested change
"enable_https_traffic_only": {
"https_traffic_only_enabled": {

or

Suggested change
"enable_https_traffic_only": {
"only_https_traffic_allowed_enabled": {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :D

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022

CLA assistant check
All committers have signed the CLA.

@abner-dou abner-dou requested a review from katbyte March 14, 2022 17:23
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abner-dou - LGTM 🦀

@katbyte katbyte merged commit 9cffeab into hashicorp:main Mar 18, 2022
@github-actions github-actions bot added this to the v1.0.0 milestone Mar 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants