Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_iothub - endpoint and route can now be cleared by setting them to [] #8028

Merged
merged 2 commits into from
Aug 11, 2020

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Aug 6, 2020

fixes #5065

--- PASS: TestAccAzureRMIotHub_fallbackRoute (245.99s)
--- PASS: TestAccAzureRMIotHub_fileUpload (303.89s)
--- PASS: TestAccAzureRMIotHub_basic (306.01s)
--- PASS: TestAccAzureRMIotHub_standard (320.62s)
--- PASS: TestAccAzureRMIotHub_ipFilterRules (330.66s)
--- PASS: TestAccAzureRMIotHub_requiresImport (336.06s)
--- PASS: TestAccAzureRMIotHub_removeEndpointsAndRoutes (467.11s)
--- PASS: TestAccAzureRMIotHub_customRoutes (514.77s)
PASS

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @neil-yechenwei - we can't do this as it breaks existing users & tests. What we need to do is change these to ConfigModeAttr and then when a user whichs to clear them they can be set to empty arrays.

@ghost ghost added size/M and removed size/S labels Aug 7, 2020
@neil-yechenwei
Copy link
Contributor Author

@katbyte , thanks for your suggestion. I've updated code. Please have a look. Thanks.

@neil-yechenwei neil-yechenwei requested a review from katbyte August 7, 2020 02:03
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neil-yechenwei - LGTM now ✨

@katbyte katbyte merged commit b06114b into hashicorp:master Aug 11, 2020
@katbyte katbyte changed the title Remove computed attribute for endpoint and route of azurerm_iothub azurerm_iothub - endpoint and route can now be cleared by setting them to [] Aug 11, 2020
katbyte added a commit that referenced this pull request Aug 11, 2020
@ghost
Copy link

ghost commented Aug 13, 2020

This has been released in version 2.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.23.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_iothub does not remove endpoints and routes
2 participants