Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

features update feature flag roll_instances_when_required for virtual_machine_scale_set to be Optional #22976

Merged
merged 1 commit into from
Oct 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion internal/provider/features.go
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,8 @@ func schemaFeatures(supportLegacyTestSuite bool) *pluginsdk.Schema {
},
"roll_instances_when_required": {
Type: pluginsdk.TypeBool,
Required: true,
Optional: true,
Default: true,
},
"scale_to_zero_before_deletion": {
Type: pluginsdk.TypeBool,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1135,8 +1135,7 @@ func (r LinuxVirtualMachineScaleSetResource) otherForceDelete(data acceptance.Te
provider "azurerm" {
features {
virtual_machine_scale_set {
force_delete = true
roll_instances_when_required = true
Copy link
Contributor Author

@myc2h6o myc2h6o Aug 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing this as it defaults to true with this change, this acc test is testing the functionality of force_delete

force_delete = true
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1348,8 +1348,7 @@ func (r WindowsVirtualMachineScaleSetResource) otherForceDelete(data acceptance.
provider "azurerm" {
features {
virtual_machine_scale_set {
force_delete = true
roll_instances_when_required = true
force_delete = true
}
}
}
Expand Down
Loading