Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_kubernetes_cluster - Use list API instead of GetAccessProfile #20927

Merged
merged 3 commits into from
Mar 20, 2023
Merged

azurerm_kubernetes_cluster - Use list API instead of GetAccessProfile #20927

merged 3 commits into from
Mar 20, 2023

Conversation

lonegunmanb
Copy link
Contributor

@lonegunmanb lonegunmanb commented Mar 14, 2023 •
edited
Loading

As #20843 described, GetAccessProfile API requires different permission than ListClusterUserCredentials and ListClusterAdminCredentials require, and according to the document:

WARNING: This API will be deprecated. Instead use ListClusterUserCredentials or ListClusterAdminCredentials .

This pr should fix #20843 by using List API instead for both datasource and resource azurerm_kubernetes_cluster.

@stephybun stephybun self-assigned this Mar 17, 2023
stephybun
stephybun reviewed Mar 17, 2023
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to apply these changes to the resource as well?

@lonegunmanb
Copy link
Contributor Author

lonegunmanb commented Mar 20, 2023 •
edited
Loading

Do we need to apply these changes to the resource as well?

Will do @stephybun

@lonegunmanb lonegunmanb requested a review from stephybun March 20, 2023 05:39
@github-actions github-actions bot added size/L and removed size/M labels Mar 20, 2023
@lonegunmanb lonegunmanb changed the title data source azurerm_kubernetes_cluster - Use list API instead of GetAccessProfile azurerm_kubernetes_cluster - Use list API instead of GetAccessProfile Mar 20, 2023
stephybun
stephybun approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lonegunmanb LGTM 🍈

@stephybun stephybun merged commit bd2e923 into hashicorp:main Mar 20, 2023
@github-actions github-actions bot added this to the v3.49.0 milestone Mar 20, 2023
stephybun added a commit that referenced this pull request Mar 20, 2023
@stephybun
Update for #20927
d9faeae
@github-actions
Copy link

This functionality has been released in v3.49.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@slzmruepp slzmruepp mentioned this pull request Mar 29, 2023
Closed
1 task
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephybun stephybun stephybun approved these changes

Assignees

@stephybun stephybun

Labels
bug service/kubernetes-cluster size/L
Projects
None yet
Milestone
v3.49.0
2 participants
@lonegunmanb @stephybun