-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource/Data Source: azurerm_recovery_services_vault
#995
Conversation
c59daeb
to
195feb2
Compare
Dependent on #1006 |
Fixes #576 |
…urerm_recovery_services_vault
Tests pass:
|
195feb2
to
5626b36
Compare
Updated the test check func to make this consistent - and the tests still pass:
and
|
azurerm_recovery_services_vault
azurerm_recovery_services_vault
azurerm_recovery_services_vault
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Will support for enrolling vm's deployed with the same template be added at a later release as well? |
@PleaseStopAsking it's on our roadmap at some point but I can't speak to a timeframe unfortunately - would you mind opening a Feature Request for this with more info of what you're after? This would allow others to 👍 the Feature Request so we can prioritise it accordingly :) |
@tombuildsstuff Thanks for the response. I will open Feature Request with further details. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
This requires azure SDK for go v14 to be vended in.