Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_app_service - allow changing client_affinity_enabled without requiring a resource recreation #993

Merged

Conversation

sabbox
Copy link
Contributor

@sabbox sabbox commented Mar 17, 2018

This PR allows to change ARR Affinity setting without destroying app service.
I've added test case but not sure how to verify properly app service not re-created

@sabbox sabbox changed the title Fix re-creation when ARR Affinity is changed Fix App Service re-creation when ARR Affinity is changed Mar 20, 2018
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @sabbox

Thanks for this PR - I've taken a look through and this LGTM 👍

Thanks!

@tombuildsstuff tombuildsstuff added this to the 1.3.1 milestone Mar 26, 2018
@tombuildsstuff
Copy link
Contributor

App Service tests pass:

screen shot 2018-03-26 at 12 02 18

@tombuildsstuff tombuildsstuff changed the title Fix App Service re-creation when ARR Affinity is changed azurerm_app_service - allow changing client_affinity_enabled without requiring a resource recreation Mar 26, 2018
@tombuildsstuff tombuildsstuff merged commit bd958b5 into hashicorp:master Mar 26, 2018
tombuildsstuff added a commit that referenced this pull request Mar 26, 2018
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants