Allow ADLS File System to have ACLs added to the root

[ross-p-smith]

This change allows the azurerm_storage_data_lake_gen2_filesystem resource to be configured with a set of ACE blocks that will be applied to the root "/" file system. This is needed as you require "--x" permission at the root if you are creating any azurerm_storage_data_lake_gen2_path resources.

The change has involved moving some of the validate/parse functions into shared code and apply the ACE functionality at the "/" path

This is to address Issue #9425

Fixes #9425

[jvanenckevort]

Excellent fix @ross-p-smith!

[ross-p-smith]

Thanks @favoretti - I have removed the files and will see if they can get reviewed under a separate PR

[tombuildsstuff]

hey @ross-p-smith

Thanks for this PR - apologies for the delayed review here!

Taking a look through on the whole this looks pretty good, if we can fix up the minor comments then this should otherwise be good to go 👍

Thanks!

[tombuildsstuff]

the id field needs to be set to a value in all cases, else this'll show as a diff - so can we make this:

Suggested change

	}
	id := ""
	if v.TagQualifier != nil {
	id = v.TagQualifier.String()
	}
	ace["id"] = id

[tombuildsstuff]

we can remove this, since this shouldn't be configured unless a user opts to do so:

Suggested change

Computed: true,

[tombuildsstuff]

minor we're using the parse folder for Resource ID Parsers rather than for Schema -> Object parsing - could we move this back up a level

[tombuildsstuff]

Chatting with @favoretti offline - @favoretti is going to send a follow-up PR to address these comments shortly so that we can get this in for this release, so I'll kick off the tests for this now - hope you don't mind @ross-p-smith

[tombuildsstuff]

Tests pass:

[tombuildsstuff]

As mentioned in this comment - @favoretti is sending a follow up to fix the remaining comments so that we can get this in for this release

[ghost]

This has been released in version 2.45.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.45.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!