-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: azurerm_eventgrid_system_topic_event_subscription
#9852
New Resource: azurerm_eventgrid_system_topic_event_subscription
#9852
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jrauschenbusch! Much of this looks great but I think we should try and consolidate as much as we can since it heavily mirrors EventGrid Event Subscription and if anything changes we'll have issues with ease of maintainability.
...internal/services/eventgrid/tests/eventgrid_system_topic_event_subscription_resource_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/eventgrid/eventgrid_system_topic_event_subscription_resource.go
Outdated
Show resolved
Hide resolved
website/docs/r/eventgrid_system_topic_event_subscription.html.markdown
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Just the bit on the .gitignore file and we'll want to add the documentation to the sidebar and we'll be good!
41ae3ee
to
a31e64d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
azurerm_eventgrid_system_topic_event_subscription
Thanks for this @jrauschenbusch! |
This has been released in version 2.41.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.41.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Solves #9141
Fixes #9141