-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow allow_blob_public_access and min_tls_version on azurerm_storage_account in USGovernmentCloud #9540
Conversation
Ready for pull. Has been tested to validate now works with Public and USGov Cloud. Screenshot provided in issue to validate these features are available is US Gov region. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ruandersMSFT - thanks for the PR. I've left a couple minor comments inline that need to be addressed. In addition to those could we remove the .vs files? thanks!
azurerm/internal/services/storage/resource_arm_storage_account.go
Outdated
Show resolved
Hide resolved
@katbyte Thanks, requested changed fixed, ready for approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ruandersMSFT - LGTM 👍
This has been released in version 2.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.40.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
No description provided.