desktopvirtualization: adding a state migration for the new ID format #9495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve parsing functions These are intended only to be used to handle a broken API Response and to rewrite this within the Provider side to avoid conflicts between Core, which expects a 1:1 Plan <-> Apply and the Azure API response, which doesn't do that.
…appropriate This allows us to workaround a bug where Core expects the Plan to 1:1 the Apply but the Azure API returns the Resource ID's in a case-insensitive manner depending on which API is being called. This clearly isn't ideal, but allows for consistency on the Terraform side whilst working around a broken API on the Azure side.
manicminer
reviewed
Nov 26, 2020
|
|
||
| { | ||
| // mixed-cased segment names | ||
| Input: "/subscriptions/12345678-1234-9876-4563-123456789012/resourceGroups/resGroup1/providers/Microsoft.DesktopVirtualization/ApPlIcAtIoNgRoUpS/applicationGroup1", |
|
Tests pass:
|
|
This has been released in version 2.38.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.38.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a state migration for each of the Desktop Virtualization resources - allowing these to be parsed insensitively and then patched up to match the apply.
This adds support for a conditional "insensitive" option within the Resource ID generator - intentionally named
rewrite, since that's what it's intended to do - which is intentionally disabled by default, since this should be a last-resort to work around a broken API response prior to patching it.You'll want to review this commit by commit, since the last one is a regeneration of all the parse functions to add some documentation to account for the optional
{Insensitive}parserUltimately this issue fixes #9491