azurerm_redis_cache - add support for notify-keyspace-events
#949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bailantaotao
force-pushed
the
feature/add-notify-keyspace-events-for-redis-configuration
branch
from
ea2b9df to
ab68ea8
Compare
bailantaotao
force-pushed
the
feature/add-notify-keyspace-events-for-redis-configuration
branch
from
ab68ea8 to
86c4b1b
Compare
tombuildsstuff
approved these changes
Mar 8, 2018
There was a problem hiding this comment.
hey @bailantaotao
Thanks for this PR - I've taken a look through and this LGTM - thanks for this 👍
Thanks!
tombuildsstuff
changed the title
azurerm_redis_cache - add support for notify-keyspace-events
| name = "unlikely23exst2acct%s" | ||
| resource_group_name = "${azurerm_resource_group.test.name}" | ||
| location = "${azurerm_resource_group.test.location}" | ||
| account_type = "Standard_GRS" |
There was a problem hiding this comment.
in running the tests I noticed this field needs to be split into the two sub-fields - I'll push a commit to fix this :)
account_tier = "Standard"
account_replication_type = "GRS"
There was a problem hiding this comment.
Oh...thanks for your help :D
|
Tests pass:
|
tombuildsstuff
added a commit
that referenced
this pull request
Mar 8, 2018
tombuildsstuff
added a commit
that referenced
this pull request
Mar 13, 2018
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add new configuration about
notify-keyspace-eventson Redis