Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source azurerm_virtual_wan #9382

Merged

Conversation

EtienneDeneuve
Copy link
Contributor

That's my first try in Go, so please be kind and helpful :)

@ghost ghost added size/XL and removed size/L labels Nov 19, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @EtienneDeneuve

Thanks for this PR :)

Taking a look through this is off to a good start - if we can fix up the comments and add an acceptance test to confirm this works going forward then we should be able to run those tests and get this merged 👍

Thanks!

website/docs/d/virtual_wan.html.markdown Outdated Show resolved Hide resolved
website/docs/d/virtual_wan.html.markdown Outdated Show resolved Hide resolved
website/docs/d/virtual_wan.html.markdown Outdated Show resolved Hide resolved
website/docs/d/virtual_wan.html.markdown Outdated Show resolved Hide resolved
EtienneDeneuve and others added 12 commits November 19, 2020 16:22
Copy link
Contributor Author

@EtienneDeneuve EtienneDeneuve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good :)

Copy link
Contributor Author

@EtienneDeneuve EtienneDeneuve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good To Go

 M go.sum Edit#    14243
 M go.sum Edit#    14243
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @EtienneDeneuve - this LGTM 👍

@katbyte katbyte added this to the v2.38.0 milestone Nov 26, 2020
@katbyte katbyte changed the title Datasource azure virtual wan New Data Source azurerm_virtual_wan Nov 26, 2020
katbyte added a commit that referenced this pull request Nov 26, 2020
@jackofallops jackofallops merged commit b97390b into hashicorp:master Nov 26, 2020
@ghost
Copy link

ghost commented Nov 27, 2020

This has been released in version 2.38.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.38.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Dec 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants