Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azurerm_linux|windows_virtual_machine - Support extensions_time_budget #9257

Merged

Conversation

ArcturusZhang
Copy link
Contributor

No description provided.

@ghost ghost added the size/XXL label Nov 11, 2020
@ArcturusZhang ArcturusZhang reopened this Nov 11, 2020
@ghost ghost added the documentation label Nov 11, 2020
@ArcturusZhang ArcturusZhang force-pushed the virtual-machine-enhancement branch from 39ed671 to 388d803 Compare November 11, 2020 05:50
@ghost ghost added size/XL and removed size/XXL labels Nov 11, 2020
@ArcturusZhang ArcturusZhang force-pushed the virtual-machine-enhancement branch from 388d803 to 308eb19 Compare November 11, 2020 05:57
@ghost ghost added size/L and removed size/XL labels Nov 11, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArcturusZhang - this LGTM 👍

@katbyte
Copy link
Collaborator

katbyte commented Nov 16, 2020

Once we fix the merge conflicts this should be good to merge

…ancement

# Conflicts:
#	azurerm/internal/services/compute/linux_virtual_machine_resource.go
#	azurerm/internal/services/compute/windows_virtual_machine_resource.go
@ArcturusZhang
Copy link
Contributor Author

Hi @katbyte I just did a merge, and the conflicts should be resolved, please have a look, thanks

…ancement

# Conflicts:
#	azurerm/internal/services/compute/windows_virtual_machine_resource.go
@jackofallops
Copy link
Member

tests looking good (failures unrelated)
image

@jackofallops jackofallops merged commit 7a3b5bd into hashicorp:master Nov 17, 2020
jackofallops added a commit that referenced this pull request Nov 17, 2020
@ArcturusZhang ArcturusZhang deleted the virtual-machine-enhancement branch November 18, 2020 05:08
@ghost
Copy link

ghost commented Dec 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants