Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_network_interface - adding support for attaching to Application Security Groups #911

Merged
merged 2 commits into from
Mar 1, 2018

Conversation

tombuildsstuff
Copy link
Contributor

No description provided.

@tombuildsstuff tombuildsstuff force-pushed the application-security-groups-nics branch from 0fe9bbf to a3010ea Compare March 1, 2018 00:06
@tombuildsstuff
Copy link
Contributor Author

Ignoring a transient Azure error - the tests pass:

screen shot 2018-02-28 at 16 28 16

@tombuildsstuff tombuildsstuff requested a review from metacpp March 1, 2018 01:29
@@ -92,6 +92,8 @@ The `ip_configuration` block supports:

* `load_balancer_inbound_nat_rules_ids` - (Optional) List of Load Balancer Inbound Nat Rules IDs involving this NIC

* `application_security_group_ids` - (Optional) List of Application Security Group IDs which should be attached to this NIC

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 this wants a Preview disclaimer here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombuildsstuff tombuildsstuff merged commit e393210 into master Mar 1, 2018
@tombuildsstuff tombuildsstuff deleted the application-security-groups-nics branch March 1, 2018 16:30
tombuildsstuff added a commit that referenced this pull request Mar 1, 2018
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants