Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cosmosdb autoscale upper cap #9050

Merged
merged 4 commits into from
Nov 16, 2020
Merged

Remove cosmosdb autoscale upper cap #9050

merged 4 commits into from
Nov 16, 2020

Conversation

favoretti
Copy link
Collaborator

MSFT support can scale accounts and containers to the skies (largest
we've heard was around 30M RUs), so capping this in terraform breaks
custom accounts and containers scaled to large wallets volumes.

@ghost ghost added the size/XS label Oct 28, 2020
@favoretti favoretti changed the title Remove cosmosdb_sql_storage_container autoscale upper cap Remove cosmosdb autoscale upper cap Oct 28, 2020
Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@favoretti thanks for submitting this PR, these changes LGTM. I think it is safe to ignore the lint errors as they are not related to your changes. 🚀

@WodansSon WodansSon added this to the v2.37.0 milestone Nov 14, 2020
Comment on lines 135 to 138
{
Value: 1100000,
Errors: 1,
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I would leave this test in the test suite but change Errors to expect 0 to verify that the upper limit on throughput has been removed. WDYT?

favoretti and others added 4 commits November 16, 2020 06:43
MSFT support can scale accounts and containers to the skies (largest
we've heard was around 30M RUs), so capping this in terraform breaks
custom accounts and containers scaled to large ~~wallets~~ volumes.
@ghost ghost added the documentation label Nov 16, 2020
@favoretti
Copy link
Collaborator Author

Thanks for fixing gents!

@WodansSon
Copy link
Collaborator

@jackofallops thanks for pushing those changes, this looks perfect now! 🚀

@WodansSon WodansSon merged commit 0d20fb3 into hashicorp:master Nov 16, 2020
WodansSon added a commit that referenced this pull request Nov 16, 2020
@ghost
Copy link

ghost commented Nov 20, 2020

This has been released in version 2.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.37.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Dec 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants