-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cosmosdb autoscale upper cap #9050
Remove cosmosdb autoscale upper cap #9050
Conversation
cosmosdb_sql_storage_container
autoscale upper capThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@favoretti thanks for submitting this PR, these changes LGTM. I think it is safe to ignore the lint errors as they are not related to your changes. 🚀
{ | ||
Value: 1100000, | ||
Errors: 1, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I would leave this test in the test suite but change Errors to expect 0 to verify that the upper limit on throughput has been removed. WDYT?
MSFT support can scale accounts and containers to the skies (largest we've heard was around 30M RUs), so capping this in terraform breaks custom accounts and containers scaled to large ~~wallets~~ volumes.
Thanks for fixing gents! |
@jackofallops thanks for pushing those changes, this looks perfect now! 🚀 |
This has been released in version 2.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.37.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
MSFT support can scale accounts and containers to the skies (largest
we've heard was around 30M RUs), so capping this in terraform breaks
custom accounts and containers scaled to large
walletsvolumes.