Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: azurerm_application_security_group #905

Merged
merged 3 commits into from
Feb 28, 2018
Merged

New Resource: azurerm_application_security_group #905

merged 3 commits into from
Feb 28, 2018

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Feb 28, 2018 •
edited
Loading

Tasks:

  • Upgrade to v12 of the Azure SDK for Go
  • Document that this is still in Public Preview
  • Fix the rebase issue in azurerm/config.go

Fixes #369

@tombuildsstuff tombuildsstuff force-pushed the application-security-groups branch from 48b1ca5 to 990ba96 Compare February 28, 2018 19:26
@tombuildsstuff tombuildsstuff added this to the 1.1.3 milestone Feb 28, 2018
@tombuildsstuff
Copy link
Contributor Author

Tests pass:

screen shot 2018-02-28 at 11 47 37

@tombuildsstuff tombuildsstuff mentioned this pull request Feb 28, 2018
Closed
@tombuildsstuff tombuildsstuff requested review from a team and katbyte and removed request for a team February 28, 2018 20:29
katbyte
katbyte reviewed Feb 28, 2018
View reviewed changes
azurerm/config.go
@@ -323,22 +324,15 @@ func getArmClient(c *authentication.Config) (*ArmClient, error) {
return keyVaultSpt, nil
})

csc := containerservice.NewContainerServicesClientWithBaseURI(endpoint, c.SubscriptionID)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm at a loss as to why this was removed as it seems unrelated?

Copy link
Contributor Author

@tombuildsstuff tombuildsstuff Feb 28, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is actually being registered twice in master at the moment (due to a previous merge conflict):

https://github.com/terraform-providers/terraform-provider-azurerm/blob/f76c05bc2cc04e0a1974d0182497abc07abeba18/azurerm/config.go#L331

https://github.com/terraform-providers/terraform-provider-azurerm/blob/f76c05bc2cc04e0a1974d0182497abc07abeba18/azurerm/config.go#L503

this consolidates this into one

katbyte
katbyte approved these changes Feb 28, 2018
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tombuildsstuff tombuildsstuff merged commit e261811 into master Feb 28, 2018
@tombuildsstuff tombuildsstuff deleted the application-security-groups branch February 28, 2018 23:07
tombuildsstuff added a commit that referenced this pull request Feb 28, 2018
@tombuildsstuff
Updating to include #905
634a69c
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
new-resource service/application-security-groups
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Feature Request: Application Security Groups
2 participants
@tombuildsstuff @katbyte