Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE Fixed: azurerm_virtual_desktop_application_group name allowed length is 3-31, should be 1-260 #8980 #9030

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

ritesh-modi
Copy link
Contributor

@ritesh-modi ritesh-modi commented Oct 27, 2020

Acceptance tests results

TF_PROVIDER_SPLIT_COMBINED_TESTS=1 TF_ACC=1 go test -v ./azurerm/internal/services/containers/tests/ -timeout=60m -run=TestAccAzureRMKubernetesCluster_sameSize
TF_ACC=1 go test -v ./azurerm/internal/services/desktopvirtualization -timeout=60m -run=TestAccAzureRMVirtualDesktopApplicationGroup_basic
=== RUN TestAccAzureRMVirtualDesktopApplicationGroup_basic
=== PAUSE TestAccAzureRMVirtualDesktopApplicationGroup_basic
=== CONT TestAccAzureRMVirtualDesktopApplicationGroup_basic
--- PASS: TestAccAzureRMVirtualDesktopApplicationGroup_basic (185.70s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/desktopvirtualization 185.749s

TF_ACC=1 go test -v ./azurerm/internal/services/desktopvirtualization -timeout=60m -run=TestAccAzureRMVirtualDesktopApplicationGroup_complete
=== RUN TestAccAzureRMVirtualDesktopApplicationGroup_complete
=== PAUSE TestAccAzureRMVirtualDesktopApplicationGroup_complete
=== CONT TestAccAzureRMVirtualDesktopApplicationGroup_complete
--- PASS: TestAccAzureRMVirtualDesktopApplicationGroup_complete (177.54s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/desktopvirtualization 177.591s

TF_ACC=1 go test -v ./azurerm/internal/services/desktopvirtualization -timeout=60m -run=TestAccAzureRMVirtualDesktopApplicationGroup_update

=== RUN TestAccAzureRMVirtualDesktopApplicationGroup_update
=== PAUSE TestAccAzureRMVirtualDesktopApplicationGroup_update
=== CONT TestAccAzureRMVirtualDesktopApplicationGroup_update
--- PASS: TestAccAzureRMVirtualDesktopApplicationGroup_update (314.00s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/desktopvirtualization 314.068s

TF_ACC=1 go test -v ./azurerm/internal/services/desktopvirtualization -timeout=60m -run=TestAccAzureRMVirtualDesktopApplicationGroup_requiresImport
=== RUN TestAccAzureRMVirtualDesktopApplicationGroup_requiresImport
=== PAUSE TestAccAzureRMVirtualDesktopApplicationGroup_requiresImport
=== CONT TestAccAzureRMVirtualDesktopApplicationGroup_requiresImport
--- PASS: TestAccAzureRMVirtualDesktopApplicationGroup_requiresImport (193.34s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/desktopvirtualization 193.410s

(fixes #8980)

@ghost ghost added the size/M label Oct 27, 2020
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ritesh-modi, this looks mostly good but it looks like a kubernetes commit snuck in. Do you mind removing that so this PR is only focused on azurerm_virtual_desktop_application_group?

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ritesh-modi, LGTM 👍

@katbyte katbyte added this to the v2.34.0 milestone Oct 28, 2020
@katbyte katbyte added the bug label Oct 28, 2020
@katbyte katbyte merged commit 288153a into hashicorp:master Oct 28, 2020
katbyte added a commit that referenced this pull request Oct 28, 2020
@ghost
Copy link

ghost commented Oct 29, 2020

This has been released in version 2.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_virtual_desktop_application_group name allowed length is 3-31, should be 1-260
3 participants