Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_mssql_database - do not set longterm and shortterm retention policies when using the DW SKUs #8899

Merged
merged 1 commit into from
Oct 15, 2020
Merged

azurerm_mssql_database - do not set longterm and shortterm retention policies when using the DW SKUs #8899

merged 1 commit into from
Oct 15, 2020

Conversation

favoretti
Copy link
Collaborator

Fixes #8898

@ghost ghost added the size/XS label Oct 15, 2020
@favoretti
Copy link
Collaborator Author

@jackofallops I heard you're running a release today - can you have a look at this one and maybe ship as a bugfix please? Our MSSQL plans are all broken :(

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @favoretti - LGTM! 👍

@katbyte katbyte added bug service/mssql Microsoft SQL Server labels Oct 15, 2020
@katbyte katbyte added this to the v2.33.0 milestone Oct 15, 2020
@katbyte katbyte changed the title Do not set LRP and SRP for MSSQL Databases with DW SKU azurerm_mssql_database - do not set longterm and shortterm retention policies when using the DW SKUs Oct 15, 2020
@katbyte katbyte merged commit 6dd869a into hashicorp:master Oct 15, 2020
katbyte added a commit that referenced this pull request Oct 15, 2020
@ghost
Copy link

ghost commented Oct 22, 2020

This has been released in version 2.33.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.33.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_mssql_database with DW SKU doesn't support retention policies
2 participants